Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snapshot should wait for isReady #140

Closed
ronag opened this issue May 31, 2016 · 1 comment
Closed

snapshot should wait for isReady #140

ronag opened this issue May 31, 2016 · 1 comment
Assignees
Milestone

Comments

@ronag
Copy link

ronag commented May 31, 2016

RecordHandler.prototype.snapshot = function( name, callback ) {
    if( this._records[ name ] && this._records[ name ].isReady ) {
       callback(null, this._records[ name ].get() );
    } else {
        this._snapshotRegistry.request( name, callback );
    }
};
ronag added a commit to nxtedition/deepstream.io-client-js that referenced this issue May 31, 2016
@WolframHempel
Copy link
Member

Yes, it should. Good find

@yasserf yasserf added this to the 1.0 milestone Jun 17, 2016
ronag added a commit to nxtedition/deepstream.io-client-js that referenced this issue Jun 18, 2016
ronag added a commit to nxtedition/deepstream.io-client-js that referenced this issue Jun 28, 2016
@timaschew timaschew added roadmap and removed ready labels Jul 20, 2016
ronag added a commit to nxtedition/deepstream.io-client-js that referenced this issue Jul 26, 2016
ronag added a commit to nxtedition/deepstream.io-client-js that referenced this issue Jul 26, 2016
yasserf pushed a commit that referenced this issue Jul 27, 2016
yasserf added a commit that referenced this issue Jul 27, 2016
@yasserf yasserf self-assigned this Jul 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants