Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit event when max reconnect attempts has been reached #175

Closed
kolpax opened this issue Jul 12, 2016 · 1 comment
Closed

Emit event when max reconnect attempts has been reached #175

kolpax opened this issue Jul 12, 2016 · 1 comment
Assignees
@timaschew
Labels
enhancement quick win

Comments

@kolpax
Copy link

kolpax commented Jul 12, 2016 •
edited by timaschew

Currently I have to count the reconnect attempts manually. Would be nice to have an event for when no more reconnect attempts will be made.

I use it to separate warnings from errors in my project. A reconnect is a warning while the last reconnect failed is an error.
@yasserf
Copy link
Contributor

yasserf commented Jul 20, 2016

We will emit a

C.EVENT.exports.MAX_RECONNECTION_ATTEMPTS_REACHED

@timaschew timaschew self-assigned this Jul 20, 2016
@coveralls coveralls mentioned this issue Jul 27, 2016
Merged
yasserf pushed a commit that referenced this issue Jul 27, 2016
@timaschew @yasserf
Feature/#175 max reconnection reached (#189)
ff84544 
emit MAX_RECONNECTION_ATTEMPTS_REACHED
yasserf pushed a commit that referenced this issue Jul 27, 2016
@timaschew @yasserf
Feature/#175 max reconnection reached (#189)
4b8d6b4 
emit MAX_RECONNECTION_ATTEMPTS_REACHED
yasserf pushed a commit that referenced this issue Jul 27, 2016
@timaschew @yasserf
Feature/#175 max reconnection reached (#189)
406bb28 
emit MAX_RECONNECTION_ATTEMPTS_REACHED
yasserf pushed a commit that referenced this issue Jul 27, 2016
@timaschew @yasserf
Feature/#175 max reconnection reached (#189)
3b6c6c8 
emit MAX_RECONNECTION_ATTEMPTS_REACHED
yasserf pushed a commit that referenced this issue Jul 27, 2016
@timaschew @yasserf
Feature/#175 max reconnection reached (#189)
8b50d6d 
emit MAX_RECONNECTION_ATTEMPTS_REACHED
@yasserf yasserf closed this as completed Jul 29, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@timaschew timaschew

Labels
enhancement quick win
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@timaschew @yasserf @kolpax