Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

discard and delete should happen after whenReady by default #94

Closed
yasserf opened this issue Apr 13, 2016 · 0 comments
Closed

discard and delete should happen after whenReady by default #94

yasserf opened this issue Apr 13, 2016 · 0 comments
Assignees
@yasserf
Labels
enhancement
Milestone
1.0

Comments

@yasserf
Copy link
Contributor

yasserf commented Apr 13, 2016 •
edited

Currently when getting doing this:

ds.record.getRecord( id ).set( data ).discard()

we would get an unsolicited message since the read would come in after the client no longer has an interest in the record.

What we should do in the API is make sure discard gets called within a whenReady callback to allow normal chaining.
@yasserf yasserf added the ready label Apr 29, 2016
@yasserf yasserf added this to the 1.0 milestone Apr 29, 2016
@yasserf yasserf self-assigned this May 15, 2016
WolframHempel added a commit that referenced this issue May 24, 2016
@WolframHempel
Merge pull request #115 from deepstreamIO/enhancement/#94-discard-del…
9d5401d 
…ete-after-whenReady

Fixes #94 Discard/Delete get called after connection ready
@yasserf yasserf removed the in review label May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yasserf yasserf

Labels
enhancement
Projects
None yet
Milestone
1.0
Development

No branches or pull requests
1 participant
@yasserf