Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

record: Always call whenReady asynchronously. Fixes #204 #206

Closed
wants to merge 2 commits into from

Conversation

ronag
Copy link

@ronag ronag commented Aug 9, 2016

I'm not sure why this is required. But without this weird stuff happens. See #204.

@ronag ronag changed the title record: Always call whenReady asynchronously. Fixed #204 record: Always call whenReady asynchronously. Fixes #204 Aug 9, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-13.6%) to 83.599% when pulling 81d897e on nxtedition:fix/#204 into 35586e4 on deepstreamIO:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-47.8%) to 49.461% when pulling cb0a23d on nxtedition:fix/#204 into 35586e4 on deepstreamIO:master.

@ronag
Copy link
Author

ronag commented Aug 9, 2016

Doesn't fix the issue.

@ronag ronag closed this Aug 9, 2016
@ronag ronag deleted the fix/#204 branch August 9, 2016 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants