Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AuthenticationHandler not plugin, dependency plugins don't specifiy t… #265

Merged
merged 1 commit into from
Jul 6, 2016

Conversation

yasserf
Copy link
Contributor

@yasserf yasserf commented Jul 5, 2016

@WolframHempel @timaschew

I was going through the documentation and testing some things, and the valve permissions never actually printed where they were being loaded from.

I know this is way too close to the 1.0 release, but I tested this and it works across all authentication handlers ( minor change ) since all of our connectors isReady events are sync ( file loads so fast it worked regardless ), and also works if they are async.

I think this should go in, but I want to get some thumbs up first incase it:

  1. Isn't urgent enough to bypass code freeze
  2. Has any implications I can't think of

@timaschew
Copy link
Contributor

Good catch!
LGTM 👍

@coveralls
Copy link

coveralls commented Jul 5, 2016

Coverage Status

Coverage increased (+0.004%) to 96.487% when pulling 642f801 on bug/auth-not-plugin into 91054a1 on master.

@timaschew timaschew merged commit 5d3d506 into master Jul 6, 2016
@yasserf yasserf deleted the bug/auth-not-plugin branch July 28, 2016 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants