fix(jsonpath): tests and code for #646 and #651

[AlexBHarley]

Courtesy of @honorcode, solves #646 and #651

Pretty happy with this, @yasserf do you want to give it a second pair of eyes.

[yasserf]

this is super expensive, doing three inline regexs and not even compiling them all upfront.

[yasserf]

This is a pretty expensive solution.. I would need to look into this more first but I think it can possibly be done in a more performant manner.

[yasserf]

I'm guessing this is also a backwards compatability change to how people used the . vs []

This is certainly correctly behaviour, just a bit concerned about impact it may cause merging it in its current state.

[AlexBHarley]

So discussed this with @yasserf a bit more. We don't want to do 3 regexes here

let str = this._path.replace(/\s/g, '')
str = str.replace(/\[(.*?)\]/g, '=$1')
const parts = str.split(SPLIT_REG_EXP)

The first two should be compiled like the third one, but ideally we'd still only want to do one.

A couple of solutions discussed to avoid the replace(regex, '=$1).

• We can store some metadata somewhere about token when surrounded by [ and ], this way we know it's an array and not a property
• Seemingly better solution:
  • when we find a token surrounded by [ and ], put it into the token array explicitly as a number (Number(token))
  • otherwise, put it in as a string (String(token))

This way inside the setValue function we can see by the type of the token, whether we should be operating on an array or object.

[yasserf]

Closing this as its pretty expensive and needs to be addressed in a different manner.