-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace hello-pepr.ts with pepr-excellent-examples repo + docs #288
Comments
Thanks for the idea. External documentation like a GitHub repo is an excellent thought. We are planning an entire epic where we plan on addressing the underlying concerns to improve the project's documentation and examples. Here is a link of the issues that we are planning on prioritizing after a few initial high priority items which includes a website where the idea is that it will be similar to Zarf's (in time). However, I'll tag this issue in a similar issue and we can track progress there. |
I chatted with Jeff and the team around this and you are right, apologies for closing. This issue is more like an epic that is never really done. This repo will start a capability demonstrating OnSchedule TODO: brainstorm a way to hook this into CI. |
This repository will undergo a change where it will consist of folders of actual Pepr modules with |
## Description `OnSchedule` implementation. This PR includes documentation and will include examples as eluded to in #288 . Creates a shadow store if and only if there is a schedule created to conserve resources. ## Related Issue Fixes #308 <!-- or --> Relates to #288 ## Type of change - [ ] Bug fix (non-breaking change which fixes an issue) - [x] New feature (non-breaking change which adds functionality) - [x] Other (security config, docs update, etc) ## Checklist before merging - [x] Test, docs, adr added or updated as needed - [x] [Contributor Guide Steps](https://github.com/defenseunicorns/pepr/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed ### Expectations - Schedule store lastTimestamp while store increments count. - When the `OnSchedule` is not used, there should be no schedulestore --------- Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com> Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
## Description A couple minor, rando fixes containing things I noticed while writing tests in #288. ## Type of change - [x] Bug fix (non-breaking change which fixes an issue) - [ ] New feature (non-breaking change which adds functionality) - [ ] Other (security config, docs update, etc) ## Checklist before merging - [ ] Test, docs, adr added or updated as needed - [ ] [Contributor Guide Steps](https://github.com/defenseunicorns/pepr/blob/main/CONTRIBUTING.md#submitting-a-pull-request) followed --------- Co-authored-by: Case Wylie <cmwylie19@defenseunicorns.com>
|
Is your feature request related to a problem? Please describe.
hello-pepr is great, but it's better as a test framework and a stream of examples.
Describe the solution you'd like
we should discuss in deeper what this should be, but it needs a lot of work.
Should include Prometheus example for scraping metrics with Grafana dashboard with PolicyReport
The text was updated successfully, but these errors were encountered: