Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Propose killing the Pepr Watch caching behavior due #642

Closed
cmwylie19 opened this issue Mar 12, 2024 · 0 comments · Fixed by #643
Closed

Propose killing the Pepr Watch caching behavior due #642

cmwylie19 opened this issue Mar 12, 2024 · 0 comments · Fixed by #643

Comments

@cmwylie19
Copy link
Collaborator

Overview

Propose killing the Pepr watch cache as it seems to create more problems that it is worth. KFC internally has a lastSeen mechanism that manages in the event of network failure or overly stale connections. Pepr seeds this with it's own tracked version of the last seen resources version per callback which is a function that uses .toString() which won't capture business logic changes in other areas of the code that function calls.

Kubernetes recommends idempotency and eventual consistency which means re-calling callback should not result in inconsistent state or failure.

Steps to reproduce

Expected result

Actual Result

Visual Proof (screenshots, videos, text, etc)

Severity/Priority

Additional Context

Add any other context or screenshots about the technical debt here.

cmwylie19 added a commit that referenced this issue Mar 13, 2024
## Description

Watch Cache is causing more problems that it is fixing. Kubernetes
Fluent Client is a way to track resource versions. We are considering
removing the watch cache from Pepr

## Related Issue

Fixes #642 
Fixes #640 (Because the security scans were stuck running for 20 mins
and I needed to restart them)
<!-- or -->
Relates to #

## Type of change

- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Other (security config, docs update, etc)

## Checklist before merging

- [ ] Test, docs, adr added or updated as needed
- [ ] [Contributor Guide
Steps](https://github.com/defenseunicorns/pepr/blob/main/CONTRIBUTING.md#submitting-a-pull-request)
followed

---------

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant