Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove watch cache from pepr #643

Merged
merged 7 commits into from
Mar 13, 2024
Merged

chore: remove watch cache from pepr #643

merged 7 commits into from
Mar 13, 2024

Conversation

cmwylie19
Copy link
Collaborator

@cmwylie19 cmwylie19 commented Mar 12, 2024

Description

Watch Cache is causing more problems that it is fixing. Kubernetes Fluent Client is a way to track resource versions. We are considering removing the watch cache from Pepr

Related Issue

Fixes #642
Fixes #640 (Because the security scans were stuck running for 20 mins and I needed to restart them)

Relates to #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Other (security config, docs update, etc)

Checklist before merging

Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
@cmwylie19 cmwylie19 marked this pull request as ready for review March 12, 2024 15:53
@cmwylie19 cmwylie19 changed the title WIP - Remove Watch Cache from Pepr Remove Watch Cache from Pepr Mar 12, 2024
@cmwylie19 cmwylie19 changed the title Remove Watch Cache from Pepr chore: remove watch cache from pepr Mar 12, 2024
@cmwylie19 cmwylie19 changed the title chore: remove watch cache from pepr chore: remove watch cache from pepr Mar 12, 2024
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Copy link
Collaborator

@btlghrants btlghrants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M'kay.

@cmwylie19 cmwylie19 merged commit 667de73 into main Mar 13, 2024
11 checks passed
@cmwylie19 cmwylie19 deleted the 642 branch March 13, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Propose killing the Pepr Watch caching behavior due Release pipeline references Zarf
2 participants