-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove watch cache from pepr #643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
requested review from
jeff-mccoy,
btlghrants and
schaeferka
as code owners
March 12, 2024 15:53
cmwylie19
changed the title
WIP - Remove Watch Cache from Pepr
Remove Watch Cache from Pepr
Mar 12, 2024
cmwylie19
changed the title
Remove Watch Cache from Pepr
chore: remove watch cache from pepr
Mar 12, 2024
cmwylie19
changed the title
chore: remove watch cache from pepr
chore: remove watch cache from pepr
Mar 12, 2024
cmwylie19
commented
Mar 12, 2024
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
cmwylie19
commented
Mar 12, 2024
btlghrants
approved these changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
M'kay.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Watch Cache is causing more problems that it is fixing. Kubernetes Fluent Client is a way to track resource versions. We are considering removing the watch cache from Pepr
Related Issue
Fixes #642
Fixes #640 (Because the security scans were stuck running for 20 mins and I needed to restart them)
Relates to #
Type of change
Checklist before merging