-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove webhooks after exiting npx pepr dev
#816
Conversation
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we covered in review, this cleans up what it can & leaves only what we can't be sure pepr:dev
created. So long as we add a note in the docs somewhere -- something to the effect of "clean up pepr-system namespace and/or peprstore CRD by hand" -- I'll approve.
Signed-off-by: Case Wylie <cmwylie19@defenseunicorns.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried to add some more context about why we're not auto-deleting those 2 things / make the items a user'd have to manually-delete a little more obvious through highlighting & bulleting.
Co-authored-by: Barrett <81570928+btlghrants@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, LG.
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [defenseunicorns/uds-common](https://togithub.com/defenseunicorns/uds-common) | | patch | `v0.4.2` -> `v0.4.3` | [![age](https://developer.mend.io/api/mc/badges/age/github-tags/defenseunicorns%2fuds-common/v0.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/defenseunicorns%2fuds-common/v0.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/defenseunicorns%2fuds-common/v0.4.2/v0.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/defenseunicorns%2fuds-common/v0.4.2/v0.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [pepr](https://togithub.com/defenseunicorns/pepr) | dependencies | patch | [`0.31.0` -> `0.31.1`](https://renovatebot.com/diffs/npm/pepr/0.31.0/0.31.1) | [![age](https://developer.mend.io/api/mc/badges/age/npm/pepr/0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pepr/0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pepr/0.31.0/0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pepr/0.31.0/0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [registry1.dso.mil/ironbank/opensource/defenseunicorns/pepr/controller](https://togithub.com/defenseunicorns/pepr) ([source](https://repo1.dso.mil/dsop/opensource/defenseunicorns/pepr/controller)) | | patch | `v0.31.0` -> `v0.31.1` | [![age](https://developer.mend.io/api/mc/badges/age/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.31.0/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/docker/registry1.dso.mil%2fironbank%2fopensource%2fdefenseunicorns%2fpepr%2fcontroller/v0.31.0/v0.31.1?slim=true)](https://docs.renovatebot.com/merge-confidence/) | | [ts-jest](https://kulshekhar.github.io/ts-jest) ([source](https://togithub.com/kulshekhar/ts-jest)) | devDependencies | patch | [`29.1.2` -> `29.1.3`](https://renovatebot.com/diffs/npm/ts-jest/29.1.2/29.1.3) | [![age](https://developer.mend.io/api/mc/badges/age/npm/ts-jest/29.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/ts-jest/29.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/ts-jest/29.1.2/29.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/ts-jest/29.1.2/29.1.3?slim=true)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>defenseunicorns/uds-common (defenseunicorns/uds-common)</summary> ### [`v0.4.3`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.4.3) [Compare Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.4.2...v0.4.3) ##### Bug Fixes - update renovate config to use docker versioning for zarf images ([#​128](https://togithub.com/defenseunicorns/uds-common/issues/128)) ([c18e125](https://togithub.com/defenseunicorns/uds-common/commit/c18e12507384328bb53b81c096bc9827f96ba114)) ##### Miscellaneous - add an airgap note to UDS Package Practices (clarity is kindness) ([#​126](https://togithub.com/defenseunicorns/uds-common/issues/126)) ([b70e1fe](https://togithub.com/defenseunicorns/uds-common/commit/b70e1fe165a521a33789298a7e69aa6a59d54968)) - adjust UDS package practice formatting ([#​123](https://togithub.com/defenseunicorns/uds-common/issues/123)) ([f351d04](https://togithub.com/defenseunicorns/uds-common/commit/f351d04732a6e6e6fc2c62eff13f625a613effcc)) - **deps:** update uds common package dependencies to v6.6.3 ([#​132](https://togithub.com/defenseunicorns/uds-common/issues/132)) ([0ebdd1f](https://togithub.com/defenseunicorns/uds-common/commit/0ebdd1f5f2aa32720c88347027215305573bc716)) - **deps:** update uds common support dependencies ([#​125](https://togithub.com/defenseunicorns/uds-common/issues/125)) ([e014724](https://togithub.com/defenseunicorns/uds-common/commit/e01472454d2b3ef9665546fbb24c9980f090d238)) - **deps:** update uds common support dependencies to v0.22.0 ([#​133](https://togithub.com/defenseunicorns/uds-common/issues/133)) ([2cf903d](https://togithub.com/defenseunicorns/uds-common/commit/2cf903d41d0dbfda1baaa9629d1fa3c5d1a88110)) - initial package practices ([#​117](https://togithub.com/defenseunicorns/uds-common/issues/117)) ([d292b21](https://togithub.com/defenseunicorns/uds-common/commit/d292b216da73493743cd0a67b9763549c87c1819)) - update package practices with a bit more feedback ([#​129](https://togithub.com/defenseunicorns/uds-common/issues/129)) ([af34fc9](https://togithub.com/defenseunicorns/uds-common/commit/af34fc90104c57d11a08678186b8b2aeaaac135d)) </details> <details> <summary>defenseunicorns/pepr (pepr)</summary> ### [`v0.31.1`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.31.1) [Compare Source](https://togithub.com/defenseunicorns/pepr/compare/v0.31.0...v0.31.1) ##### What's Changed - chore: updates based on KFC changes by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#825 - chore: remove webhooks after exiting `npx pepr dev` by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#816 - chore: bump chainguard/node-lts from `ad74234` to `352823f` by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#809 - chore: bump github/codeql-action from 2.13.4 to 3.25.5 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#808 - chore: bump github/codeql-action from 3.25.5 to 3.25.6 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#818 - chore: bump chainguard/node-lts from `352823f` to `5ac3e57` by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#817 - chore: bump ts-jest from 29.1.2 to 29.1.3 in the development-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#821 - chore: bump library/node from `9e8f45f` to `9456710` by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#823 - chore: bump chainguard/node-lts from `5ac3e57` to `4f3a934` by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#820 **Full Changelog**: defenseunicorns/pepr@v0.31.0...v0.31.1 </details> <details> <summary>kulshekhar/ts-jest (ts-jest)</summary> ### [`v29.1.3`](https://togithub.com/kulshekhar/ts-jest/blob/HEAD/CHANGELOG.md#2913-2024-05-21) [Compare Source](https://togithub.com/kulshekhar/ts-jest/compare/v29.1.2...v29.1.3) ##### Bug Fixes - add `@jest/transform` as an optional peer dependency ([0ba7f86](https://togithub.com/kulshekhar/ts-jest/commit/0ba7f861c3e1905de5627b4e5d2a2cadad011b67)) - bring back Node 14 support ([eda56a7](https://togithub.com/kulshekhar/ts-jest/commit/eda56a779789d70963b7572e2914b2a3a25ac43a)) ##### Performance Improvements - remove ts resolved module cache file ([4c88da5](https://togithub.com/kulshekhar/ts-jest/commit/4c88da58991b000aa90ea489acfa6aed39b36120)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ1cGRhdGVkSW5WZXIiOiIzNy4zNjguMTAiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Megamind <882485+jeff-mccoy@users.noreply.github.com>
Description
This clears up issue 739 and removes the webhooks by listening for
SIGINT
on the process and listening forclose
on the program (child process) and upon receiving the signal removing the webhooks with aPromise.all
.Test:
Related Issue
Fixes #739
Relates to #
Type of change
Checklist before merging