refactor: run build in container #826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eddiezane
requested review from
jeff-mccoy,
cmwylie19,
btlghrants and
schaeferka
as code owners
eddiezane
force-pushed
the
ez/update-dockerfile
branch
from
058abdb
to
53d0459
Compare
eddiezane
commented
May 23, 2024
eddiezane
force-pushed
the
ez/update-dockerfile
branch
2 times, most recently
from
ffcc2b1
to
5aaacad
Compare
eddiezane
commented
May 23, 2024
eddiezane
force-pushed
the
ez/update-dockerfile
branch
from
5aaacad
to
b4da618
Compare
Signed-off-by: Eddie Zaneski <eddiezane@gmail.com>
eddiezane
force-pushed
the
ez/update-dockerfile
branch
from
b4da618
to
f95f3d1
Compare
cmwylie19
approved these changes
May 28, 2024
|
LGTM, works, nice enhancement! |
|
We will be ready to update the |
mjnagel
added a commit
to defenseunicorns/uds-core
that referenced
this pull request
Jun 14, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---|---|---| | [defenseunicorns/uds-common](https://togithub.com/defenseunicorns/uds-common) | | minor | `v0.4.5` -> `v0.5.1` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [pepr](https://togithub.com/defenseunicorns/pepr) | dependencies | minor | [`0.31.1` -> `0.32.2`](https://renovatebot.com/diffs/npm/pepr/0.31.1/0.32.2) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | | [registry1.dso.mil/ironbank/opensource/defenseunicorns/pepr/controller](https://togithub.com/defenseunicorns/pepr) ([source](https://repo1.dso.mil/dsop/opensource/defenseunicorns/pepr/controller)) | | minor | `v0.31.1` -> `v0.32.2` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>defenseunicorns/uds-common (defenseunicorns/uds-common)</summary> ### [`v0.5.1`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.5.1) [Compare Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.5.0...v0.5.1) ##### Miscellaneous - upgrade uds cli-cli to v0.11.2 ([#​150](https://togithub.com/defenseunicorns/uds-common/issues/150)) ([3f23c6d](https://togithub.com/defenseunicorns/uds-common/commit/3f23c6d9845cec860851f4476e54eb0199e20625)) ### [`v0.5.0`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.5.0) [Compare Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.4.6...v0.5.0) ##### ⚠ BREAKING CHANGES - update publish to take architecture as an input ([#​143](https://togithub.com/defenseunicorns/uds-common/issues/143)) ##### Miscellaneous - update publish to take architecture as an input ([#​143](https://togithub.com/defenseunicorns/uds-common/issues/143)) ([62620f5](https://togithub.com/defenseunicorns/uds-common/commit/62620f59c14c773e5f6f07aaafc70ae34cff36bd)) ### [`v0.4.6`](https://togithub.com/defenseunicorns/uds-common/releases/tag/v0.4.6) [Compare Source](https://togithub.com/defenseunicorns/uds-common/compare/v0.4.5...v0.4.6) ##### Bug Fixes - renovate incorrectly matching oci helm charts for helm datasources ([#​141](https://togithub.com/defenseunicorns/uds-common/issues/141)) ([2761f2a](https://togithub.com/defenseunicorns/uds-common/commit/2761f2a5f69bae3967bb8a9ff6d392007f90a21b)) ##### Miscellaneous - allow debug logs to continue through failure ([#​146](https://togithub.com/defenseunicorns/uds-common/issues/146)) ([bec4fc3](https://togithub.com/defenseunicorns/uds-common/commit/bec4fc330d720673f645bda7e56006218ec96aad)) - **deps:** update uds common support dependencies to v0.22.1 ([#​144](https://togithub.com/defenseunicorns/uds-common/issues/144)) ([d618bd2](https://togithub.com/defenseunicorns/uds-common/commit/d618bd2be3f75d62346594cb8d6d8c339b074f93)) </details> <details> <summary>defenseunicorns/pepr (pepr)</summary> ### [`v0.32.2`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.32.2) [Compare Source](https://togithub.com/defenseunicorns/pepr/compare/v0.32.1...v0.32.2) #### What's Changed - chore: load_image by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#893 **Full Changelog**: defenseunicorns/pepr@v0.32.1...v0.32.2 ### [`v0.32.1`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.32.1) [Compare Source](https://togithub.com/defenseunicorns/pepr/compare/v0.32.0...v0.32.1) #### What's Changed - chore: add files to publish to registry by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#891 - chore: bump pino-pretty from 11.2.0 to 11.2.1 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#887 - chore: bump github/codeql-action from 3.25.8 to 3.25.9 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#886 - chore: bump actions/checkout from 4.1.6 to 4.1.7 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#885 **Full Changelog**: defenseunicorns/pepr@v0.32.0...v0.32.1 ### [`v0.32.0`](https://togithub.com/defenseunicorns/pepr/releases/tag/v0.32.0) [Compare Source](https://togithub.com/defenseunicorns/pepr/compare/v0.31.1...v0.32.0) #### Features - feat: add flag for chart based zarf.yaml and update templated fields in chart deployments by [@​zachariahmiller](https://togithub.com/zachariahmiller) in [defenseunicorns/pepr#830 - feat: included digestabot by [@​naveensrinivasan](https://togithub.com/naveensrinivasan) in [defenseunicorns/pepr#868 #### What's Changed - chore: secure workflow file by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#870 - chore: clear cache on failure by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#866 - chore: revert - this caused dependency conflicts by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#876 - chore: security audit to remove vulnerability by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#879 - chore: fix release pipeline after error with the dist folder due to building in a container by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#882 - chore: update dependabot to include peerDependencies by [@​schaeferka](https://togithub.com/schaeferka) in [defenseunicorns/pepr#857 - fix: contribute guide link in template by [@​eddiezane](https://togithub.com/eddiezane) in [defenseunicorns/pepr#827 - refactor: run build in container by [@​eddiezane](https://togithub.com/eddiezane) in [defenseunicorns/pepr#826 - chore: warning message not readable by [@​schaeferka](https://togithub.com/schaeferka) in [defenseunicorns/pepr#838 - chore: update error messages by [@​schaeferka](https://togithub.com/schaeferka) in [defenseunicorns/pepr#844 - chore: ossf scorecard security updates for workflow files by [@​cmwylie19](https://togithub.com/cmwylie19) in [defenseunicorns/pepr#850 - chore: bump actions/upload-artifact from 4.3.1 to 4.3.3 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#862 - chore: bump actions/dependency-review-action from 4.3.2 to 4.3.3 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#861 - chore: bump chainguard/node-lts from `3d635a3` to `5bcab86` by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#863 - chore: bump step-security/harden-runner from 2.8.0 to 2.8.1 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#867 - chore: bump pino-pretty from 11.1.0 to 11.2.0 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#872 - chore: bump kubernetes-fluent-client from 2.6.0 to 2.6.1 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#839 - chore: bump chainguard/node-lts from `49163a9` to `3d635a3` by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#845 - chore: bump github/codeql-action from 3.25.6 to 3.25.7 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#846 - chore: bump ramda from 0.30.0 to 0.30.1 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#849 - chore: bump [@​types/node](https://togithub.com/types/node) from 18.19.33 to 18.19.34 in the development-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#852 - chore: bump github/codeql-action from 3.25.7 to 3.25.8 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#851 - chore: bump chainguard/node-lts from `4f3a934` to `64578d8` by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#828 - chore: bump pino-pretty from 11.0.0 to 11.1.0 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#829 - chore: bump docker/login-action from 3.1.0 to 3.2.0 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#834 - chore: bump ts-jest from 29.1.3 to 29.1.4 in the development-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#833 - chore: bump chainguard-dev/digestabot from 1.0.2 to 1.1.0 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#877 - chore: bump pino from 9.1.0 to 9.2.0 in the production-dependencies group by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#883 #### New Contributors - [@​eddiezane](https://togithub.com/eddiezane) made their first contribution in [defenseunicorns/pepr#827 - [@​zachariahmiller](https://togithub.com/zachariahmiller) made their first contribution in [defenseunicorns/pepr#830 - chore: bump chainguard-dev/digestabot from 1.0.2 to 1.0.3 by [@​dependabot](https://togithub.com/dependabot) in [defenseunicorns/pepr#871 **Full Changelog**: defenseunicorns/pepr@v0.31.1...v0.32.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://togithub.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/defenseunicorns/uds-core). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zOTMuMCIsInVwZGF0ZWRJblZlciI6IjM3LjM5My4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Micah Nagel <micah.nagel@defenseunicorns.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the build process for pepr builds the code outside of the container and then copies the transpiled code in.
This PR changes the build process to run the build step inside of a container. This ensures that builds are fully reproducible and not dependent on external tooling. It also streamlines building pepr locally.
Related Issue
Type of change
Checklist before merging