Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restructure zarf config yaml #71

Merged
merged 8 commits into from
Oct 3, 2021
Merged

Restructure zarf config yaml #71

merged 8 commits into from
Oct 3, 2021

Conversation

jeff-mccoy
Copy link
Contributor

Closes #64 and helps cleanup #40 (comment)

@jeff-mccoy
refactor zarf config structure
faa2393 
- features -> components
- everything is now a component
- added a "required" flag for components
- remove local zarf.yaml key
- remote -> utility-cluster
- removed viper dependency
- simplified config read/write
@jeff-mccoy
rename configSingleton
6538c7d
@jeff-mccoy
update kubescape url
1b7a393
@jeff-mccoy jeff-mccoy marked this pull request as ready for review October 1, 2021 15:55
@jeff-mccoy
Copy link
Contributor Author

Passing build and E2E: https://repo1.dso.mil/platform-one/big-bang/apps/product-tools/zarf/-/pipelines/508564

@jeff-mccoy jeff-mccoy mentioned this pull request Oct 1, 2021
Closed
@RothAndrew
Copy link
Contributor

Good stuff. Taking a look now.

@RothAndrew RothAndrew self-requested a review October 1, 2021 17:48
@RothAndrew
Copy link
Contributor

Update: haven't even had a chance to look at this yet. Meetings are blowing up my day. The code all looks fine to me, I did want to deploy each example to make sure none of them were broken.

@RothAndrew
Copy link
Contributor

Okay pinky swear I'm actually looking now

@RothAndrew
Copy link
Contributor

@jeff-mccoy can you try the big bang example? I think the utility cluster stuff isn't working, want to make sure it isn't just a "me" thing

@RothAndrew
Copy link
Contributor

image

The command finishes waaaay faster than it used to, and I don't see any repos in gitea

image

@jeff-mccoy
Copy link
Contributor Author

It did feel too easy, I’ll check it out

@RothAndrew RothAndrew mentioned this pull request Oct 1, 2021
Closed
@RothAndrew
Copy link
Contributor

It looks like zarf package deploy is missing the --components flag. Want to add it here or do it in a new PR? I'm fine with either.

@RothAndrew
Copy link
Contributor

image

@jeff-mccoy
Copy link
Contributor Author

Good catch, I’ll get that in this pr too later this evening

@RothAndrew
Copy link
Contributor

LGTM other than the --components flag being missing

@jeff-mccoy
Copy link
Contributor Author

Screen Shot 2021-10-03 at 2 18 55 AM

Screen Shot 2021-10-03 at 2 16 37 AM

Screen Shot 2021-10-03 at 2 16 47 AM

@jeff-mccoy jeff-mccoy merged commit e2ee947 into master Oct 3, 2021
@jeff-mccoy jeff-mccoy deleted the feature/restructure-zarf-config-yaml branch October 3, 2021 13:11
@RothAndrew RothAndrew changed the title Feature/restructure zarf config yaml Restructure zarf config yaml Oct 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RothAndrew RothAndrew RothAndrew approved these changes

Assignees

@jeff-mccoy jeff-mccoy

@RothAndrew RothAndrew

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expanding Zarf Features to regular zarf packages
2 participants
@jeff-mccoy @RothAndrew