Underlines show up in the wrong positions on outlook.com #134
Assignees
Labels
Comments
sbrudz
added a commit
that referenced
this issue
Sep 29, 2021
This fixes an issue with the underlines in emails on outlook.com appearing above the words. The root cause was that outlook.com changed the DOM structure, adding padding to the contenteditable div that was the normal parent as well as adding another containing div with no `position` attribute to the hierarchy. The new intermediate was being used as the parent for calculating coords but the coords of the words were relative to the contenteditable div. Using offsetParent instead of parentNode skips the intermediate div and makes things line up properly. fixes #134
sbrudz
added a commit
that referenced
this issue
Sep 29, 2021
This fixes an issue with the underlines in emails on outlook.com appearing above the words. The root cause was that outlook.com changed the DOM structure, adding padding to the contenteditable div that was the normal parent as well as adding another containing div with no `position` attribute to the hierarchy. The new intermediate was being used as the parent for calculating coords but the coords of the words were relative to the contenteditable div. Using offsetParent instead of parentNode skips the intermediate div and makes things line up properly. fixes #134
just-not-sorry-bot
pushed a commit
that referenced
this issue
Sep 29, 2021
|
🎉 This issue has been resolved in version 2.0.0-beta.12 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
just-not-sorry-bot
pushed a commit
that referenced
this issue
Dec 30, 2021
# 2.1.0-beta.1 (2021-12-30) ### Bug Fixes * **outlook.com:** fix positioning of underlines on outlook.com ([cdbff91](cdbff91)), closes [#134](#134) * correctly trigger warnings when matched text is on separate lines ([857847b](857847b)) * ensure that "we believe" is highlighted as a warning ([0797b29](0797b29)) * ensure that "we feel" is highlighted as a warning ([a1cf47b](a1cf47b)) * fix issue with line breaks not triggering warning detection in outlook.live.com ([b22f8bf](b22f8bf)) * fix issue with warnings not appearing for first line of email text ([2b93a40](2b93a40)), closes [#117](#117) * fix leaky divs ([836f1f1](836f1f1)) * fixing increase in checkForWarnings function call ([765260a](765260a)) * highlighting issues on outlook and gmail 117 ([ece2480](ece2480)) * keyword '!!!' was not working with plugin ([3c28f94](3c28f94)) * loosen rules for just 'does that make sense' ([da95bf0](da95bf0)) * outlook doesn't id its contenteditable divs ([aa0f1cc](aa0f1cc)) * remove boundary conditions on regex for !!! ([514b932](514b932)) * remove extra space after sentence ([1046cbd](1046cbd)) * reset wait time back to originaly value of 500 ([6e811e6](6e811e6)) * support contenteditable divs with no id ([a7b9cbc](a7b9cbc)) * support multiline phrase highlighting ([3d7281c](3d7281c)) * use correct textContent method on html node element and remove extraneous set state call ([6aa8515](6aa8515)) * warning not clearing after keyword is deleted ([f55290d](f55290d)) * wrong state key being used ([f77c733](f77c733)) * **performance:** changes to improve performance ([bca3ac9](bca3ac9)) * **warnings:** fix issue with highlights not showing up in certain cases ([0ee2810](0ee2810)), closes [#117](#117) ### Features * add support for outlook.live.com ([2de1661](2de1661)), closes [#102](#102) * add white border to warning tooltip for better visibility ([85bab84](85bab84)) * display list of warnings in options dialog ([c6cbe22](c6cbe22)), closes [#57](#57) * provide feedback about changes when extension is updated ([672af8d](672af8d)) * use notifications instead of opening a new tab to alert users of updates ([c7ef536](c7ef536)) * **options:** generate options dialog using a template ([6c191b7](6c191b7)) ### Performance Improvements * change calc time from 500 to 1 ([2f0f2cf](2f0f2cf)) ### Reverts * **phrases:** revert looser rules on phrase highlighting ([2db3676](2db3676))
|
🎉 This issue has been resolved in version 2.1.0-beta.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
just-not-sorry-bot
pushed a commit
that referenced
this issue
Dec 30, 2021
# 2.1.0 (2021-12-30) ### Bug Fixes * **outlook.com:** fix positioning of underlines on outlook.com ([cdbff91](cdbff91)), closes [#134](#134) * correctly trigger warnings when matched text is on separate lines ([857847b](857847b)) * ensure that "we believe" is highlighted as a warning ([0797b29](0797b29)) * ensure that "we feel" is highlighted as a warning ([a1cf47b](a1cf47b)) * fix issue with line breaks not triggering warning detection in outlook.live.com ([b22f8bf](b22f8bf)) * fix issue with warnings not appearing for first line of email text ([2b93a40](2b93a40)), closes [#117](#117) * fix leaky divs ([836f1f1](836f1f1)) * fixing increase in checkForWarnings function call ([765260a](765260a)) * highlighting issues on outlook and gmail 117 ([ece2480](ece2480)) * keyword '!!!' was not working with plugin ([3c28f94](3c28f94)) * loosen rules for just 'does that make sense' ([da95bf0](da95bf0)) * outlook doesn't id its contenteditable divs ([aa0f1cc](aa0f1cc)) * remove boundary conditions on regex for !!! ([514b932](514b932)) * remove extra space after sentence ([1046cbd](1046cbd)) * reset wait time back to originaly value of 500 ([6e811e6](6e811e6)) * support contenteditable divs with no id ([a7b9cbc](a7b9cbc)) * support multiline phrase highlighting ([3d7281c](3d7281c)) * use correct textContent method on html node element and remove extraneous set state call ([6aa8515](6aa8515)) * warning not clearing after keyword is deleted ([f55290d](f55290d)) * wrong state key being used ([f77c733](f77c733)) * **performance:** changes to improve performance ([bca3ac9](bca3ac9)) * **warnings:** fix issue with highlights not showing up in certain cases ([0ee2810](0ee2810)), closes [#117](#117) ### Features * add support for outlook.live.com ([2de1661](2de1661)), closes [#102](#102) * add white border to warning tooltip for better visibility ([85bab84](85bab84)) * display list of warnings in options dialog ([c6cbe22](c6cbe22)), closes [#57](#57) * provide feedback about changes when extension is updated ([672af8d](672af8d)) * use notifications instead of opening a new tab to alert users of updates ([c7ef536](c7ef536)) * **options:** generate options dialog using a template ([6c191b7](6c191b7)) ### Performance Improvements * change calc time from 500 to 1 ([2f0f2cf](2f0f2cf)) ### Reverts * **phrases:** revert looser rules on phrase highlighting ([2db3676](2db3676))
|
🎉 This issue has been resolved in version 2.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
sbrudz
pushed a commit
that referenced
this issue
Jan 11, 2022
# 2.1.0 (2021-12-30) ### Bug Fixes * **outlook.com:** fix positioning of underlines on outlook.com ([cdbff91](cdbff91)), closes [#134](#134) * correctly trigger warnings when matched text is on separate lines ([857847b](857847b)) * ensure that "we believe" is highlighted as a warning ([0797b29](0797b29)) * ensure that "we feel" is highlighted as a warning ([a1cf47b](a1cf47b)) * fix issue with line breaks not triggering warning detection in outlook.live.com ([b22f8bf](b22f8bf)) * fix issue with warnings not appearing for first line of email text ([2b93a40](2b93a40)), closes [#117](#117) * fix leaky divs ([836f1f1](836f1f1)) * fixing increase in checkForWarnings function call ([765260a](765260a)) * highlighting issues on outlook and gmail 117 ([ece2480](ece2480)) * keyword '!!!' was not working with plugin ([3c28f94](3c28f94)) * loosen rules for just 'does that make sense' ([da95bf0](da95bf0)) * outlook doesn't id its contenteditable divs ([aa0f1cc](aa0f1cc)) * remove boundary conditions on regex for !!! ([514b932](514b932)) * remove extra space after sentence ([1046cbd](1046cbd)) * reset wait time back to originaly value of 500 ([6e811e6](6e811e6)) * support contenteditable divs with no id ([a7b9cbc](a7b9cbc)) * support multiline phrase highlighting ([3d7281c](3d7281c)) * use correct textContent method on html node element and remove extraneous set state call ([6aa8515](6aa8515)) * warning not clearing after keyword is deleted ([f55290d](f55290d)) * wrong state key being used ([f77c733](f77c733)) * **performance:** changes to improve performance ([bca3ac9](bca3ac9)) * **warnings:** fix issue with highlights not showing up in certain cases ([0ee2810](0ee2810)), closes [#117](#117) ### Features * add support for outlook.live.com ([2de1661](2de1661)), closes [#102](#102) * add white border to warning tooltip for better visibility ([85bab84](85bab84)) * display list of warnings in options dialog ([c6cbe22](c6cbe22)), closes [#57](#57) * provide feedback about changes when extension is updated ([672af8d](672af8d)) * use notifications instead of opening a new tab to alert users of updates ([c7ef536](c7ef536)) * **options:** generate options dialog using a template ([6c191b7](6c191b7)) ### Performance Improvements * change calc time from 500 to 1 ([2f0f2cf](2f0f2cf)) ### Reverts * **phrases:** revert looser rules on phrase highlighting ([2db3676](2db3676))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tami was testing the latest release and found the following issue on outlook.com:
The text was updated successfully, but these errors were encountered: