Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically add extra Android packages when calling AAPT #6047

Closed
britzl opened this issue Sep 13, 2021 · 1 comment · Fixed by defold/extender#248
Closed

Automatically add extra Android packages when calling AAPT #6047

britzl opened this issue Sep 13, 2021 · 1 comment · Fixed by defold/extender#248
Assignees
Labels
android Issue related to the Android platform bob Issues related to the bob command line build tool extender Issues related to the Defold extender/build service feature request A suggestion for a new feature

Comments

@britzl
Copy link
Contributor

britzl commented Sep 13, 2021

Is your feature request related to a problem? Please describe (REQUIRED):
Android extension creators usually need to specify extra packages to pass into the Android AAPT tool while building to ensure all resources are included. The Android Gradle plugin most likely figures out which packages to add. The Defold build process should be able to do the same.

Describe the solution you'd like (REQUIRED):
The Defold build pipeline should automatically figure out which extra packages to pass into the AAPT build step.

Describe alternatives you've considered (REQUIRED):
Continue to manually define it per extension.

Additional context (OPTIONAL):
Add any other context or screenshots about the feature request here.

@britzl britzl added feature request A suggestion for a new feature extender Issues related to the Defold extender/build service bob Issues related to the bob command line build tool android Issue related to the Android platform labels Sep 13, 2021
@AGulev
Copy link
Contributor

AGulev commented Dec 30, 2021

As I understand, all the AARs that have res folder should be included using --extra-packages this.aar.package.name or even for all AARs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
android Issue related to the Android platform bob Issues related to the bob command line build tool extender Issues related to the Defold extender/build service feature request A suggestion for a new feature
Projects
No open projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants