Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed duplicate symbol for iOS in glfw library #6302

Merged
merged 1 commit into from Jan 4, 2022

Conversation

JCash
Copy link
Contributor

@JCash JCash commented Jan 4, 2022

No description provided.

Comment on lines +45 to 47
extern _GLFWwin g_Savewin;
extern UIWindow* g_ApplicationWindow;
extern AppDelegate* g_ApplicationDelegate;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have similar variables that are shared once.
Still uncertain why the linker works locally.

@JCash JCash requested a review from britzl January 4, 2022 09:50
@JCash JCash merged commit 738e38e into dev Jan 4, 2022
Copy link
Contributor

@britzl britzl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@britzl britzl deleted the ios-duplicate-symbol-fix branch January 4, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants