Collection factories are broken in bundled builds

[dapetcu21]

Describe the bug (REQUIRED)
1.4.3 broke collection factories for us. In bundled builds collectionfactory.create() returns an empty table and nothing gets spawned. When running from the editor this doesn’t happen.

To Reproduce (REQUIRED)
Steps to reproduce the behavior:
We don't have a minimal repro case, but our code looks like this:

  local instance = collectionfactory.create(self.factory_url, nil, nil, {
    [hash("character")] = {
      -- some stuff
    }
  })
  pprint(instance) -- Empty table

The collection factory is not loaded dynamically, nor does it have a dyamic prototype

Defold version (REQUIRED):

• Version 1.4.3 (1.4.2 was fine)

Platforms (REQUIRED):

• First noticed this on web, but then managed to repro on macOS too

[dapetcu21]

Oh! Here's more info:

ERROR:GAMEOBJECT: Could not create script component, out of resources.
ERROR:GAMESYS: Sprite could not be created since the buffer is full (8). Increase the 'sprite.max_count' value in [game.project](defold://open?path=/game.project)
ERROR:GAMESYS: Sprite could not be created since the buffer is full (8). Increase the 'sprite.max_count' value in [game.project](defold://open?path=/game.project)
ERROR:GAMESYS: Sprite could not be created since the buffer is full (8). Increase the 'sprite.max_count' value in [game.project](defold://open?path=/game.project)
ERROR:GAMESYS: Label could not be created since the buffer is full (0). Increase the 'label.max_count' value in [game.project](defold://open?path=/game.project)

[AGulev]

could you pls show how your setup looks like in the collection's outline?

If you use external cache when build with bob, could you pls try turn it off?

[dapetcu21]

Not using any special flags for bob. Actually bundled straight from the editor:

[AGulev]

What is your game.project label.max_count and sprite.max_count ?

[dapetcu21]

Definitely not 0 and 8. Lemme check.

[sprite]
max_count = 1024

[label]
max_count = 2048

[AGulev]

it is definitely a bug with components counter which were fully reworked in 1.4.3 to avoid issues with cache system.
But I can't reproduce it on my side (

[AGulev]

what do you use to spawn level1.collection? collectionproxy?

[dapetcu21]

Yeah, collectionproxy. It's a monarch scene

[dapetcu21]

Maybe it's because the collection factory is in characters.collection, which is dropped into level1.collection?

[AGulev]

I made the same hierarchy and it works fine for me, it should be something else...

[AGulev]

could you show me character.collection as well?

[dapetcu21]

[AGulev]

still works for me (

[dapetcu21]

Want me to give you the project?

[AGulev]

That would be helpful, yes. Because for now I've no idea why it's happening (I understand where and don't understand why). You can share it with me privately here on github or using some other way

[dapetcu21]

Yup. Give me a bit to remove some stuff so it's easy to test

[AGulev]

Thank you!

[dapetcu21]

Sent! https://github.com/critique-gaming/rethink-collections-bug It should boot you straight to the problem area. In the editor it should work fine (after skipping tutorial, it should show a character), but when bundled it soft-locks when the first char should be shown.

[AGulev]

Great, thx! I'll take a look

[AGulev]

Now I can repo it, thx!

[AGulev]

@dapetcu21 Thanks to your example I found the issue. I'll prepare a PR tomorrow.