Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use merge node markers to remove Android manifest tags #229

Merged
merged 2 commits into from
May 11, 2022

Conversation

britzl
Copy link
Contributor

@britzl britzl commented May 10, 2022

It is now possible to use a merge node marker in the AndroidManifest.xml to indicate that a tag added from a library dependency should be removed:

<!-- remove the android.permission.READ_EXTERNAL_STORAGE permission if it exists in a library dependency-->
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="remove" />

Previous extender versions did not enable this feature of the manifest merge tool and any attempt to use a merge node marker was ignored.

@britzl britzl requested a review from JCash May 10, 2022 13:27
@britzl britzl merged commit fd86609 into dev May 11, 2022
@britzl britzl deleted the Issue-223-remove-android-manifest-tags branch May 11, 2022 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants