Platform include support #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JCash
commented
Jan 25, 2023
Comment on lines
+484
to
+491
| includes.add( ExtenderUtil.getRelativePath(jobDirectory, new File(dir, "include" + File.separator + this.platform) ) ); | ||
|
|
||
| String[] platformParts = this.platform.split("-"); | ||
| if (platformParts.length == 2) { | ||
| includes.add( ExtenderUtil.getRelativePath(jobDirectory, new File(dir, "include" + File.separator + platformParts[1]))); | ||
| } | ||
|
|
||
| includes.add( ExtenderUtil.getRelativePath(jobDirectory, new File(dir, "include") ) ); |
There was a problem hiding this comment.
Adds platform folders like so:
extension/include/x86_64-win32
extension/include/win32
extension/include
britzl
approved these changes
Jan 26, 2023
| includes.add( ExtenderUtil.getRelativePath(jobDirectory, new File(buildDirectory, extDir.getName())) ); // where we generate source from protobuf files | ||
| includes.add( ExtenderUtil.getRelativePath(jobDirectory, uploadDirectory) ); | ||
| includes.add( ExtenderUtil.getRelativePath(jobDirectory, uploadDirectory) ); //TODO: Do we ever put stuff here? Isn't it more useful to include the build folder? |
There was a problem hiding this comment.
I don't think we ever put anything in the root of the upload folder no.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.