New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix for setting the spine scene to a cloned node #70
Conversation
bool create_bones = node->m_FindBones ? false : true; // See comment in GuiClone() | ||
return SetupNode(spine_scene, resource, node, create_bones); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In short, we'll find the gui nodes the next frame.
The cloning of a node is dealt with by the gui system, and it clones the node and its bones.
dst->m_FindBones = 1; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just moving it closer to the documentation
main/main.gui_script
Outdated
@@ -120,7 +130,8 @@ function init(self) | |||
|
|||
for i, bone_id in ipairs(bone_names) do | |||
--print("SCRIPT bone", bone_id) | |||
local bone = gui.get_node(bone_id) | |||
--local bone = gui.get_node(bone_id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indentation
main/main.gui_script
Outdated
@@ -109,6 +109,16 @@ function init(self) | |||
print("gui.get_spine_scene", gui.get_spine_scene(self.n)) | |||
|
|||
|
|||
--self.clone = gui.clone(self.n) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solution looks good. Indentation and commented code.
No description provided.