Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WSDL Support to resolve issue #32 #34

Merged
merged 2 commits into from Nov 16, 2012
Merged

Conversation

glennschler
Copy link
Contributor

Instead of only changing the static WSDL "Version" string which was in the the request.js file, I have added an option to set a configuration parameter named wsdlVersion. Any place which the other configuration parameters can be set or overridden, wsdlVersion may be used as well. This change will now allow support for all future updates of the wsdl by Amazon.

In order to be backward compatible for existing projects referencing this project, I have left the old static version as it was 2011-05-15. Perhaps it's worth setting to the most recent version, though it's a minor point since awz changes the wsdl a number of times each year.

bigeasy pushed a commit that referenced this pull request Nov 16, 2012
WSDL Support to resolve issue #32.
@bigeasy bigeasy merged commit 590b876 into defunct:master Nov 16, 2012
@bigeasy
Copy link
Collaborator

bigeasy commented Nov 16, 2012

When the day is done, I'll update the version number and push this to NPM. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants