make .empty just clear the .innerHTML

defunctzombie · Jan 7, 2013 · b032ab1 · b032ab1
1 parent 1b94e72
commit b032ab1
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/lib/mutation.js b/lib/mutation.js
@@ -54,9 +54,7 @@ module.exports.before = function(el, what) {
 };
 
 module.exports.empty = function(parent) {
-    var childNodes = parent.childNodes
-    for (var j=0 ; j<childNodes.length ; ++j) {
-        parent.removeChild(childNodes[j]);
-    }
+    // cheap way to remove all children
+    parent.innerHTML = '';
 };
 
diff --git a/test/manipulation.js b/test/manipulation.js
@@ -80,10 +80,10 @@ test('replace save', function() {
 suite('.empty');
 
 test('empty', function() {
-    var div = dom('<div><p>foo</p></div>');
+    var div = dom('<div><p>foo</p><p>bar</p></div>');
     var p = div.find('p');
 
-    assert.equal('<p>foo</p>', div.html());
+    assert.equal('<p>foo</p><p>bar</p>', div.html());
     div.empty();
     assert.equal('', div.html());
 });