XFF ip list #2
Merged
XFF ip list #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's with the merge commit? |
… value index.js: split comma-delimited ip lists to get first value, use try block to not fail on unexpected values tests/index: add tests for comma-delimited ip list and other unexpected xff values
|
When you accepted the first PR, locally I just merged my branch into my forked master. Now on this PR, it seems to want to add that back in, since the progress was still built on the forked repo. I don't know. I just rebased on this master (even though it's the same code) and it seems to have fixed it. |
…t happens outside the loop for each override key
defunctzombie
added a commit
that referenced
this pull request
Oct 6, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.