repo_config.buildallfile will never be false

defunkt · Jul 24, 2010 · 7647535 · 7647535
1 parent 2c8269f
commit 7647535
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/lib/cijoe.rb b/lib/cijoe.rb
@@ -48,7 +48,7 @@ def pid
   # kill the child and exit
   def stop
     # another build waits
-    if repo_config.buildallfile && File.exist?(repo_config.buildallfile.to_s)
+    if !repo_config.buildallfile.to_s.empty? && File.exist?(repo_config.buildallfile.to_s)
       # clean out on stop
       FileUtils.rm(repo_config.buildallfile.to_s)
     end
@@ -80,7 +80,7 @@ def finish_build(status, output)
     @last_build.notify if @last_build.respond_to? :notify
 
     # another build waits
-    if repo_config.buildallfile && File.exist?(repo_config.buildallfile.to_s)
+    if !repo_config.buildallfile.to_s.empty? && File.exist?(repo_config.buildallfile.to_s)
       # clean out before new build
       FileUtils.rm(repo_config.buildallfile.to_s)
       build
@@ -92,7 +92,7 @@ def finish_build(status, output)
   def build
     if building?
       # only if switched on to build all incoming requests
-      if repo_config.buildallfile
+      if !repo_config.buildallfile.to_s.empty?
         # and there is no previous request
         return if File.exist?(repo_config.buildallfile.to_s)
         # we will mark awaiting builds