Skip to content

Commit

Permalink
don't force key redefinition in major-mode hook
Browse files Browse the repository at this point in the history
- One exists keymap per major-mode.  There is no reason to keep writing the
  same thing to it in the mode definition.
- By doing this, the user is forced to customize key-bindings in a inefficient
  way (i.e. in a mode hook instead of "eval-after-load").
  • Loading branch information
Le Wang committed Jul 7, 2012
1 parent c45c5f7 commit e8b2ab6
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions coffee-mode.el
Expand Up @@ -122,7 +122,15 @@ with CoffeeScript."
:type 'hook
:group 'coffee)

(defvar coffee-mode-map (make-keymap)
(defvar coffee-mode-map (let ((map (make-sparse-keymap)))
;; key bindings
(define-key map (kbd "A-r") 'coffee-compile-buffer)
(define-key map (kbd "A-R") 'coffee-compile-region)
(define-key map (kbd "A-M-r") 'coffee-repl)
(define-key map [remap comment-dwim] 'coffee-comment-dwim)
(define-key map "\C-m" 'coffee-newline-and-indent)
(define-key map "\C-c\C-o\C-s" 'coffee-cos-mode)
map)
"Keymap for CoffeeScript major mode.")

;;
Expand Down Expand Up @@ -548,14 +556,6 @@ previous line."
"Coffee"
"Major mode for editing CoffeeScript."

;; key bindings
(define-key coffee-mode-map (kbd "A-r") 'coffee-compile-buffer)
(define-key coffee-mode-map (kbd "A-R") 'coffee-compile-region)
(define-key coffee-mode-map (kbd "A-M-r") 'coffee-repl)
(define-key coffee-mode-map [remap comment-dwim] 'coffee-comment-dwim)
(define-key coffee-mode-map "\C-m" 'coffee-newline-and-indent)
(define-key coffee-mode-map "\C-c\C-o\C-s" 'coffee-cos-mode)

;; code for syntax highlighting
(setq font-lock-defaults '((coffee-font-lock-keywords)))

Expand Down

0 comments on commit e8b2ab6

Please sign in to comment.