Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

You're only able to extend/override $.facebox.settings by using the $.fn. #40

Merged
merged 1 commit into from
Nov 2, 2011

Conversation

dragoonis
Copy link
Contributor

You're only able to extend/override $.facebox.settings by using the $.fn.facebox method, however you're unable to do so using the $.facebox(..) method. This fix lets you do just that.

….fn.facebox method, however you're unable to do so using the $.facebox(..) method. This fix lets you do just that.
@dragoonis
Copy link
Contributor Author

@defunkt

Here is my example code with the 'settings' param.

$('.item .moreinfo a').click(function() {
    var ajaxUrl = baseUrl + 'cat/product_dialog/' + $(this).attr('rel').replace('product_id_', '');
    $.facebox({
        settings: {
            closeImage:   baseUrl + 'images/facebox.closelabel.png',
            loadingImage: baseUrl + 'images/facebox.loading.gif'
        },
        ajax: ajaxUrl
    });
    return false;
});

defunkt added a commit that referenced this pull request Nov 2, 2011
You're only able to extend/override $.facebox.settings by using the $.fn.
@defunkt defunkt merged commit 30d3f05 into defunkt:master Nov 2, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants