Shorten station name in the title as well #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejas
approved these changes
Mar 16, 2024
|
Could you fix the tests? |
|
I believe the failing test has nothing to do with my changes, does it? It's asking for a package-lock file, which is not present on the master either. |
|
@KristjanESPERANTO could that be related to your PR ? |
|
Yes, that's the issue. I read up on it and it seems you are supposed to always commit package-lock. |
|
You're right. I'm fixing this now. |
|
I have successfully tested the new function and find it very good. Thank you very much! Sorry for causing trouble with the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, thanks for your work, I've been using your module for quite some time now and it's great, especially during the strikes atm ;)
I have a very small suggestion for improvement: I think it would make sense that not only the station names for the destination is shortened, but also the station name in the title row. No need to tell me I'm in Berlin again. Before the change, it said for me "Sundgauer Str. (Berlin)". Now it just says "Sundgauer Str." in the title.