Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove PHP requirements from composer.json #22

Merged
merged 1 commit into from
Dec 17, 2020

Conversation

tmotyl
Copy link

@tmotyl tmotyl commented Sep 18, 2019

It doesn't make sense to add PHP requirements in composer.json as they are now: (php 5.5, 5.6, 7.0, 7.1)

  • this configuration prevents from using the package in PHP 7.2
  • Magento 2 doesnt support php 5.5. or 5.6, so it doesnt make sense to specify it here
  • This is M2 module, so we should rely on magento PHP requirements
    for every new PHP version this line needs to be updated

It doesn't make sense to add PHP requirements in composer.json
@amenk
Copy link

amenk commented Jan 10, 2020

Please merge this :-) Is it abandoned ?

amenk added a commit to iMi-digital/magento2-gotosku that referenced this pull request Jan 10, 2020
amenk added a commit to iMi-digital/imageslider that referenced this pull request Jan 10, 2020
@jantzenw jantzenw merged commit 9e945c4 into degdigital:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants