Remove currency check

[Resonious]

We support multi-currency now, so this code is now more harmful than helpful.

[degicat]

@Agroang can you help us review this PR, please?

[Agroang]

Forgive my lack of PHP and Woocommerce knowledge but out of curiosity, as far as I can read we are no longer limited to JPY thanks to "multi-currency", so that check for apply_filters('woocommerce_komoju_supported_currencies', ['JPY']) is no longer needed.
When it comes to the actual currencies supported by "multi-currency" (USD, EUR, JPY, SGD, HKD and AUD?), is there any scenario where the user might try to use a different currency not included in the above and create an error? Or is option based among the mentioned above (so they can only choose among the supported ones)?

[Resonious]

@Agroang I actually don't know the list of currencies we support. I'm guessing this:

[JPY, USD, TWD, EUR, KRW, PLN, AUD, NZD, SGD, HKD, GBP, IDR, MYR, PHP, THB, CNY, USDC]

So one alternative way to do this would be to keep the the code here, but use that list instead of just JPY. The only issue there is that if we add more currencies to our core offering, the plugin needs a code update 😞. Maybe we should add currencies to our /api/v1/meta so that this plugin can pull the list directly from the source.

[Agroang]

@Resonious I see, I was just picking up the list from our woocommerce read me for supported payout currencies as it was using the same "multi currency" keyword 😅.

It does sounds like a code update per added currency for the plugin is costly and not very efficient.
Something like pulling the list directly as you mentioned as a possible solution sounds like a better approach.

Nevertheless, at least for this PR, my only concern was that taking off the check on JPY would allow users to "try" to use any currency (maybe ones that are not included in what we consider "multi-currency"?) but if that is not possible then I don't think that scenario may arise.

Just to confirm, are you ok with merging as it is? If above is true then I don't want to keep blocking the merge 😅

[Resonious]

@Agroang Ah I see. Good catch with the readme, haha. I think that readme line makes a good case for this PR, because it says "Accept payments in local currency", but right now "local currency" only means "JPY".

You're correct that users can attempt any currency, and our system will fail to create a payment if it is unsupported.

I think in most cases, this is something that the merchant would test before releasing live. I don't anticipate any sudden failures of existing live setups, so I'm okay with merging this 👍 (then hopefully we can find time to put the limit back, but make it dynamic based on what KOMOJU supports 😁)

[Agroang]

Got it! Thanks for the further explanation and sorry for the delay! 😸

[kvhees]

Our DCC feature will convert if it's not supported by KOMOJU, if they have enabled it.

[Resonious]

Ah alright - sounds like this is fine as-is then 👍