Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved windows support #12

Merged
merged 2 commits into from
Aug 3, 2017
Merged

Improved windows support #12

merged 2 commits into from
Aug 3, 2017

Conversation

fredZen
Copy link
Contributor

@fredZen fredZen commented Aug 1, 2017

As discussed in degree9/boot-npm#21

With this commit, boot-exec

  • can now run .cmd, .bat files etc
  • now supports the :local and :global options on windows

- can now run .cmd, .bat files etc
- :local and :global options now work on windows
@burn2delete
Copy link
Member

Have we confirmed this solves the issue in degree9/boot-npm#21 ?

Copy link
Member

@burn2delete burn2delete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great, just waiting to confirm this fixes the intended issue.

@fredZen
Copy link
Contributor Author

fredZen commented Aug 2, 2017

Thank you for the quick response, I appreciate it!

Yes, I have confirmed on a local build that this solves the issue.

I used the following method:

  • in boot-exec directory, run boot develop. This install boot-exec-1.1.0-SNAPSHOT.jar to my local maven repository
  • in boot-npm directory, edit build.boot file, change boot-exec dependency to [degree9/boot-exec "1.1.0-SNAPSHOT"]
  • in boot-npm directory, run boot develop. This install boot-npm-1.5.0-SNAPSHOT.jar to my local maven repository
  • in my project, change boot-npm dependency to [degree9/boot-npm "1.5.0-SNAPSHOT" :scope "test"], confirm that npm now runs on windows

@burn2delete burn2delete merged commit e1a2166 into degree9:master Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants