-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for reading git last commit #28
Conversation
I wonder if there is a better name we can give these functions? It would be cool if we could also pass an index to the commands to fetch a commit from further back in the history. |
This is great! 👍 |
This will be worked on as part of |
That's great, will we have two separate tasks? I like the |
Yes, another task will be provided for interacting with git, it will also provide things like creating feature and version branches |
It is also a nice idea to get a |
Agreed, added to keep dependencies low. |
@arichiardi @jgrzebyta version |
but then:
|
@arichiardi could you try this again? Here is my test:
|
uhm yeah, here it does not work @flyboarder weird...I am using |
@arichiardi could you try a version of clojure 1.8 or 1.7? |
Tried, now working, it looks like the conversion of |
@arichiardi I found the issue, if git commit id starts with a digit the entire string is assumed a number, if it starts with a letter the string is a correct string. |
Oh wow, here is something I did not know about the reader, maybe it is some sort of optimization. |
@arichiardi Yeah I didnt know that either. I am pushing |
Confirm it is working fine now |
This will however break From: Andrea Richiardi notifications@github.com Confirm it is working fine now — |
Oh I was using them more then git 😄 ...we can maybe put a |
@arichiardi Can you give |
yep! 😄
|
Ok one last try 😸 |
Works! but I have a question 😃 below
|
@arichiardi This PR only selected the first 5 chars. I will fix for version |
Ok fair enough, I just thought it was a bug as usually you need 7, but I don't know what is the actual usage of it in the wild. Also, |
@arichiardi Thanks for all the awesome testing! Helps so much! 😺 |
I have added a support for reading git last commit:
semver-git returns full number of the last commit as string
semver-short-git returns only 5 first characters from the number.