Week 4 Submission #65
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsanjabi
reviewed
Sep 12, 2022
There was a problem hiding this comment.
Looks solid! Despite green tests, I was getting an error when using Dagit unless I removed the challenge problem from the repo.py file. Something to consider if you ran into that problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(.venv) frasermarlow@Elementl corise-dagster % asermarlow@Elementl corise-dagster % make week_4_tests
================================================================================================================ test session starts ================================================================================================================
platform darwin -- Python 3.10.6, pytest-7.1.3, pluggy-0.13.1 -- /Users/frasermarlow/corise-dagster/.venv/bin/python3.10
cachedir: .pytest_cache
rootdir: /Users/frasermarlow/corise-dagster, configfile: pytest.ini
plugins: anyio-3.6.1
collected 11 items
week_4/tests/test_answer.py::test_stock PASSED [ 9%]
week_4/tests/test_answer.py::test_stock_class_method PASSED [ 18%]
week_4/tests/test_answer.py::test_aggregation PASSED [ 27%]
week_4/tests/test_answer.py::test_get_s3_data PASSED [ 36%]
week_4/tests/test_answer.py::test_process_data PASSED [ 45%]
week_4/tests/test_answer.py::test_put_redis_data PASSED [ 54%]
week_4/tests/test_answer.py::test_get_s3_data_docker PASSED [ 63%]
week_4/tests/test_answer.py::test_process_data_docker PASSED [ 72%]
week_4/tests/test_answer.py::test_put_redis_data_docker PASSED [ 81%]
week_4/tests/test_resources.py::test_s3_resource PASSED [ 90%]
week_4/tests/test_resources.py::test_redis_resource PASSED [100%]
================================================================================================================= warnings summary ==================================================================================================================
.venv/lib/python3.10/site-packages/redis/connection.py:77
/Users/frasermarlow/corise-dagster/.venv/lib/python3.10/site-packages/redis/connection.py:77: UserWarning: redis-py works best with hiredis. Please consider installing
warnings.warn(msg)
-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html
=========================================================================================================== 11 passed, 1 warning in 0.77s ===========================================================================================================
(.venv) frasermarlow@Elementl corise-dagster % clear