Skip to content

Commit

Permalink
doc(pkg/healthsrv/healthz_handler.go): clarifying docs
Browse files Browse the repository at this point in the history
  • Loading branch information
Aaron Schlesinger committed Feb 9, 2016
1 parent e792bcc commit 9f39dff
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions pkg/healthsrv/healthz_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,7 @@ type healthZResp struct {

func healthZHandler(nsLister NamespaceLister, bLister BucketLister, serverCircuit *sshd.Circuit) http.Handler {
return http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
// there's a race between the boolean eval and the HTTP error returned, but k8s will repeat the health probe request
// and effectively re-evaluate the boolean.
// There's a race between the boolean eval and the HTTP error returned (the server could start up between the two), but k8s will repeat the health probe request and effectively re-evaluate the boolean. The result is that the server may not start until the next probe in those cases
if serverCircuit.State() != sshd.ClosedState {
str := fmt.Sprintf("SSH Server is not yet started")
log.Err(str)
Expand Down

0 comments on commit 9f39dff

Please sign in to comment.