Skip to content

Commit

Permalink
fix(Makefile): speed up all makefile builds
Browse files Browse the repository at this point in the history
before, we ran ‘glide nv’ before *all* commands, but it was only used
in the ‘test’ target. this commit only runs it as part of that target
  • Loading branch information
Aaron Schlesinger committed Feb 11, 2016
1 parent 3ec3d8c commit c20fdb4
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,6 @@ RC := manifests/deis-${SHORT_NAME}-rc.yaml
SVC := manifests/deis-${SHORT_NAME}-service.yaml
IMAGE := ${DEIS_REGISTRY}${IMAGE_PREFIX}/${SHORT_NAME}:${VERSION}

TEST_PACKAGES := $(shell ${DEV_ENV_CMD} glide nv)

all:
@echo "Use a Makefile to control top-level building of the project."

Expand All @@ -46,7 +44,7 @@ build:
@$(call check-static-binary,$(BINARY_DEST_DIR)/boot)

test:
${DEV_ENV_CMD} go test ${TEST_PACKAGES}
${DEV_ENV_CMD} sh -c 'go test $$(glide nv)'

docker-build:
docker build --rm -t ${IMAGE} rootfs
Expand Down

0 comments on commit c20fdb4

Please sign in to comment.