feat(deployments): move components to use deployments instead of RC #346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jchauncey, @krancour and @arschles are potential reviewers of this pull request based on my analysis of |
| spec: | ||
| replicas: 1 | ||
| strategy: | ||
| type: Recreate |
There was a problem hiding this comment.
For others to understand, Recreate is the important difference here compared to Controller / Router which use RollingUpdate
|
@krancour can you check the logger components? |
|
database component looks good to me. My only concern before was the rolling deployment model, but recreate should work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #337 #338 #339