Add healthchecks #60
Merged
Add healthchecks #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 6, 2016
|
One tradeoff here is increased logging--lots of this in the controller log: 10.246.13.1 "GET /health-check HTTP/1.1" 200 2 "Go 1.1 package http"
10.246.13.1 "GET /health-check HTTP/1.1" 200 2 "Go 1.1 package http" |
|
hmm... is there a way we can tell django-rest-framework (or Django) to shut off logging for that specific API view? |
|
we can do that in a followup though. This looks god for now :) |
|
I have been tinkering with logging and trying to hide the above messages. I think it is feasible but it is not straightforward. I'll keep trying and make a separate PR when I succeed. See deis/workflow#252. |
|
|
This was referenced Jan 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds liveness and readiness HTTP probes to the workflow RC manifest deis-dev beta chart.