This repository has been archived by the owner on May 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 53
ref(scheduler): fetch object storage credentials from API instead of local secret #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
is this going in for beta? object storage secret is not yet implemented in slugrunner |
This can go into beta if I just keep it as |
Also this requires a change in helm charts removing secret volume mount in controller rc |
Ref deis/workflow#97 |
@helgi has this been tested? |
helgi
added a commit
that referenced
this pull request
Mar 17, 2016
ref(scheduler): fetch object storage credentials from API instead of local secret
if this is going in we should hold off the current testing and wait for the new images |
Looks like it's already merged :) |
Already merged and master for it was already built https://travis-ci.org/deis/controller/builds/116716881 |
oops my bad |
duanhongyi
pushed a commit
to duanhongyi/workflow
that referenced
this pull request
Dec 4, 2018
chore(changelogs): add v2.6.0 changelog
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now fetch the minio credentials from the API
ref #458
ref #521
Note: I can change it to to object-storage if someone points me to the doc what to use instead