Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

ref(scheduler): fetch object storage credentials from API instead of local secret #523

Merged
merged 1 commit into from
Mar 17, 2016

Conversation

helgi
Copy link
Contributor

@helgi helgi commented Mar 17, 2016

For now fetch the minio credentials from the API

ref #458
ref #521

Note: I can change it to to object-storage if someone points me to the doc what to use instead

@codecov-io
Copy link

Current coverage is 82.90%

Merging #523 into master will not affect coverage as of 2f73bb4

@@            master   #523   diff @@
=====================================
  Files           32     32       
  Stmts         1919   1919       
  Branches       271    271       
  Methods          0      0       
=====================================
  Hit           1591   1591       
  Partial         61     61       
  Missed         267    267       

Review entire Coverage Diff as of 2f73bb4

Powered by Codecov. Updated on successful CI builds.

@smothiki smothiki added the LGTM1 label Mar 17, 2016
@smothiki
Copy link
Contributor

is this going in for beta? object storage secret is not yet implemented in slugrunner

@helgi
Copy link
Contributor Author

helgi commented Mar 17, 2016

This can go into beta if I just keep it as minio-user which is what slugrunner expects based on what you said

@helgi helgi added this to the v2.0-beta1 milestone Mar 17, 2016
@smothiki
Copy link
Contributor

Also this requires a change in helm charts removing secret volume mount in controller rc

@helgi
Copy link
Contributor Author

helgi commented Mar 17, 2016

deis/charts#168

@arschles
Copy link
Member

Ref deis/workflow#97

@arschles
Copy link
Member

@helgi has this been tested?

helgi added a commit that referenced this pull request Mar 17, 2016
ref(scheduler): fetch object storage credentials from API instead of local secret
@helgi helgi merged commit 72acdf7 into deis:master Mar 17, 2016
@helgi helgi deleted the minio-from-api branch March 17, 2016 18:37
@smothiki
Copy link
Contributor

if this is going in we should hold off the current testing and wait for the new images

@arschles
Copy link
Member

Looks like it's already merged :)

@helgi
Copy link
Contributor Author

helgi commented Mar 17, 2016

Already merged and master for it was already built https://travis-ci.org/deis/controller/builds/116716881

@smothiki
Copy link
Contributor

oops my bad

duanhongyi pushed a commit to duanhongyi/workflow that referenced this pull request Dec 4, 2018
chore(changelogs): add v2.6.0 changelog
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants