Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

[meta] Project reorg before beta #4952

Closed
3 tasks done
slack opened this issue Mar 4, 2016 · 13 comments
Closed
3 tasks done

[meta] Project reorg before beta #4952

slack opened this issue Mar 4, 2016 · 13 comments
Assignees
Milestone

Comments

@slack
Copy link
Member

slack commented Mar 4, 2016

Need to update a few things in the project structure before we cut beta:

  1. Move deis/workflow to deis/controller
    • re-write client go imports to reference github.com/deis/controller
    • fixup client build scripts for bintray (if needed)
    • fixup jenkins/travis to push to deisci/controller
  2. Move deis/docs-v2 to deis/workflow (References rename to deis/workflow-docs workflow#23)
  3. Update deis/charts/deis{-dev} to point to deis/charts/workflow-{dev}

/cc @sgoings @helgi

@slack slack added this to the v2.0-beta1 milestone Mar 4, 2016
@sgoings sgoings self-assigned this Mar 4, 2016
@helgi
Copy link
Contributor

helgi commented Mar 4, 2016

Biggest problem I envision from this is the fact we are moving docs into the old workflow. It will confuse things for people if they are not aware of that change where as if docs were not moving into workflow then it would be a far more obvious error.

@sgoings
Copy link
Member

sgoings commented Mar 4, 2016

Better to do it now than later I suppose though, @helgi...

@helgi
Copy link
Contributor

helgi commented Mar 4, 2016

@sgoings agreed - just pointing out the likely error scenario when we effectively swap one project with another in the same git path

@bacongobbler
Copy link
Member

Anyone feel like breaking stuff? When should we rip the band-aid? 🔨

@mboersma
Copy link
Member

mboersma commented Mar 4, 2016

Before beta? Seriously?

@slack
Copy link
Member Author

slack commented Mar 5, 2016

We will make the call on Monday.

@mboersma
Copy link
Member

mboersma commented Mar 6, 2016

Before beta?

My apologies for getting worked up about this. If we can get 'er done, let's do it. Let's see where we are on Monday.

@arschles
Copy link
Member

arschles commented Mar 7, 2016

Note that the client has been moved to https://github.com/deis/workflow-cli. That repository is a work in progress...

@arschles
Copy link
Member

deis/workflow-cli is now up & deploying to bintray. All related issues are now closed, and the appropriate checkboxes in the description have been checked off.

@bacongobbler
Copy link
Member

if nobody else it tacking the deisci/controller job stuff, I'd be happy to tackle that.

@bacongobbler
Copy link
Member

fixup jenkins/travis to push to deisci/controller

done in deis/workflow#494, and the charts will now reference the component name as "controller" in deis/charts#153. Now all that's lefts is the holistic lift n' shift to deis/controller or deis/deis on the github side of things. There is also documentation that needs updating.

@bacongobbler
Copy link
Member

Okay, I've filed a bunch of issues. To summarize:

deis/charts#126
deis/charts#155 (while breaking things anyways)
deis/router#141
deis/workflow-cli#20
deis/workflow-cli#21

Are some things that need to be discussed before I go further down the rabbit hole. The rest is mostly documentation, but these issues basically cover the architectural changes that require discussion.

@sgoings
Copy link
Member

sgoings commented Mar 15, 2016

Superseded by #4962 (funny how the digits are so similar...)

@sgoings sgoings closed this as completed Mar 15, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants