This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
(proposal): use registry-to-registry transfer #1227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 18 commits
June 26, 2014 08:21
The endpoint introduced in this branch is important as it allows registry-to-registry repository transfers. This is required to speed up the `deis build` process and to remove the docker engine from the controller.
The intention of the docker engine was such that we could use it to pull in an image from a registry and push it to our own. Now that we have registry transfers, this is no longer required.
Since docker-in-docker is not installed on the controller any more, let's revert back to the private module.
This reverts commit 6505b63.
This reverts commit cc7100f.
This reverts commit 1611d08.
Some things changed with the version bump like how the docker registry process is started and where dependencies are installed from.
This setting is useful for id index.docker.io ever changes.
This change allows us to import an image from a remote repository, thanks to a new feature implemented in https://github.com/deis/docker-registry/compare/repository-import. Though the infrastructure in place allows us to import an image from the public index, the endpoints are closed-source and therefore are not implmented in the upstream repository-import branch.
|
ping @gabrtv for review |
|
tasklist as per @gabrtv's review:
|
added 5 commits
June 27, 2014 13:09
Publishing a release should only know about a source, a dictionary of configuration, and a target.
The logic has been moved over to the registry, so it's not needed any more.
Registry repository imports does not like tags.
`docker build` can take a while, which times out the builders. Adding a larger timeout gives us some more leeway.
This reverts commit f3a8756.
|
Merging into the |
bacongobbler
pushed a commit
that referenced
this pull request
Jul 11, 2014
(proposal): use registry-to-registry transfer
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that this is a PR made against the
deis-buildbranch.Instead of running a docker engine in the controller, I implemented a new feature to the registry that allows a user to pull in a repository from one registry to another. This greatly simplifies the
deis-buildPR. Note that the public index does not work due to the endpoints being (mostly) closed source. This must be implemented upstream in https://github.com/deis/docker-registry/compare/repository-import.The meat of this is hard to write tests for, but will get added eventually in the upstream PR before this is merged into master. I just needed this PR to work and get some discussion going :)
I've also contributed some fixes to the comments that I made in #1190