This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(Dockerfile): ensure apt-get install is prefixed by update
#1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
For reference, deis/base installs: make ca-certificates net-tools sudo wget vim strace lsof netcat |
|
@mboersma It looks like we should combine |
| RUN echo "deb http://get.docker.io/ubuntu docker main" > /etc/apt/sources.list.d/docker.list | ||
| RUN apt-key adv --keyserver keyserver.ubuntu.com --recv-keys 36A1D7869245C8950F966E92D8576A8BA88D21E9 | ||
| RUN apt-get update -qy | ||
| RUN apt-get install -yq lxc-docker-1.0.0 | ||
| RUN apt-get update && apt-get install -yq lxc-docker-1.0.0 |
There was a problem hiding this comment.
Any reason we can't move this up into the main install block? I'd prefer to avoid two updates if we can help it. We can add the Docker repository, then do an update and install all packages in one fell swoop.
|
I also updated the Go install in logger to 1.2.2, because 1.2.1 was no longer available at the speedy Docker-Index-friendly URL. |
|
Code LGTM. |
Since Dockerfile layers are cached, having `apt-get update` as a separate command creates the potential for a subsequent `apt-get install` to fail. Best practices (other than "install from source") seem to be to make both commands into a one-liner. This PR ensures we don't `apt-get install` as its own command anywhere, removes the installation of some packages that were already in deis/base, and removes a redundant ENV DEBIAN_FRONTEND statement.
|
Jenkins, test this please. |
mboersma
added a commit
that referenced
this pull request
Jul 15, 2014
fix(Dockerfile): ensure `apt-get install` is prefixed by `update`
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Dockerfile layers are cached, having
apt-get updateas a separatecommand creates the potential for a subsequent
apt-get installto fail.Best practices (other than "install from source") seem to be to make
both commands into a one-liner.
This PR ensures we don't
apt-get installas its own command anywhere,removes the installation of some packages that were already in deis/base,
and removes a redundant ENV DEBIAN_FRONTEND statement.
See also #1246 for discussion.