Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

Accept ECDSA keys in keys:add #1263

Merged
merged 2 commits into from
Jul 7, 2014
Merged

Accept ECDSA keys in keys:add #1263

merged 2 commits into from
Jul 7, 2014

Conversation

public
Copy link
Contributor

@public public commented Jul 6, 2014

Fixes #1262

@deis-bot
Copy link

deis-bot commented Jul 6, 2014

Thanks for the contribution! Please ensure your commits follow our style guide. This code will be tested once a Deis maintainer reviews it.

@public
Copy link
Contributor Author

public commented Jul 6, 2014

Not sure how I should test this. test_keys.py doesn't seem to setup the SSH keys it uses in the tests and just hopes that whatever is ~/.ssh is right?

@bacongobbler
Copy link
Member

You could add server-side tests that ensure RSA and ECDSA keys are accepted and invalid keys are refused. Sadly the client tests have been left unloved for a while, but we're interested in resurrecting them when we re-write the client in Go :)

@public
Copy link
Contributor Author

public commented Jul 6, 2014

@bacongobbler Added some ECDSA tests.

@carmstrong
Copy link
Contributor

👍 Code LGTM!

@mboersma mboersma added this to the 0.10.0 milestone Jul 7, 2014
@mboersma
Copy link
Member

mboersma commented Jul 7, 2014

@public, could you amend your commit messages for our style guide please? Something like feat(controller): accept ECDSA keys in keys:add.

Code LGTM. Thanks very much!

bacongobbler pushed a commit that referenced this pull request Jul 7, 2014
Accept ECDSA keys in keys:add
@bacongobbler bacongobbler merged commit 5f16997 into deis:master Jul 7, 2014
@public
Copy link
Contributor Author

public commented Jul 8, 2014

I guess not then :-)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECDSA SSH keys are not supported
5 participants