This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(tests): increase component test timeouts to 20min #1316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code LGTM. |
|
Code LGTM |
|
Code LGTM as well. |
|
Sould we bump this higher for the |
|
Yes, maybe builder gets 30 minutes. I'll update the PR. |
Most component test failures in our CI system recently have been due to the tests taking longer than the default Go testing package timeout of 10 minutes. The tests are in progress, but Go kills the process after 10 minutes and reports it as failed. The tradeoff here is that if one of the tests is actually stuck, we wait twice as long to find that out, but overall this seems like a fix for CI stability. Builder was increased to 30m since it takes much longer to pull slugbuilder.
mboersma
added a commit
that referenced
this pull request
Jul 14, 2014
fix(tests): increase component test timeouts to 20min
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some component test failures in our CI system recently have been due
to the tests taking longer than the default Go testing package timeout
of 10 minutes. The tests are in progress, but Go kills the process
after 10 minutes and reports it as failed.
The tradeoff here is that if one of the tests is actually stuck,
we wait twice as long to find that out, but overall this seems like a
fix for CI stability.
Timeout failure examples:
http://ci.deis.io//job/test-router/136/console
http://ci.deis.io/job/test-controller/138/console