This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(registry): use confd templated config #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code LGTM. |
1 similar comment
|
Code LGTM. |
A regression from #1190 was introduced where the config file used was the sample that came from dotcloud/docker-registry instead of using the confd templated config we use today. Updating the file to upstream's changes with the common layer as well as changing the reference to the file in the Dockerfile fixes this regression.
|
Jenkins, test this please. |
bacongobbler
pushed a commit
that referenced
this pull request
Jul 22, 2014
fix(registry): use confd templated config
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A regression from #1190 was introduced where the config file used
was the sample that came from dotcloud/docker-registry instead of
using the confd templated config we use today. Updating the file
to upstream's changes with the common flavor as well as changing
the reference to the file in the Dockerfile fixes this regression.