This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
ref(builder): switch to pre-receive hook #2227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code LGTM. "7 additions and 29 deletions" is great too. |
|
also fixes #1774 code lgtm |
aledbf
added a commit
to aledbf/deis
that referenced
this pull request
Oct 22, 2014
aledbf
added a commit
to aledbf/deis
that referenced
this pull request
Oct 22, 2014
gabrtv
pushed a commit
that referenced
this pull request
Oct 23, 2014
ref(builder): switch to pre-receive hook
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR switches the builder from a
post-receivehook to apre-receivehook, so that a failure in the build stage will not update refs. This allows the user to re-push the app without having to bump a commit.Fixes #1798
Fixes #1874