This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(store): block metadata start until confd runs #4117
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We faced a race condition where the MDS could start and initialize with an invalid keyring file, since it hadn't yet been templated by confd.
| @@ -47,6 +47,11 @@ if ! etcdctl --no-sync -C $ETCD get ${ETCD_PATH}/filesystemSetupComplete >/dev/n | |||
| fi | |||
| fi | |||
|
|
|||
| until confd -onetime -node $ETCD --confdir /app --log-level error; do | |||
There was a problem hiding this comment.
isn't this covered by lines 11-14? If that passes, the keyring file should be templated. Odd...
There was a problem hiding this comment.
Yep, came to the same conclusion a few minutes ago...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We faced a race condition where the MDS could start and initialize
with an invalid keyring file, since it hadn't yet been templated
by confd.
closes #4115