This repository has been archived by the owner on Nov 30, 2021. It is now read-only.
fix(database): use ETCD host during database recovery detection #4402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -65,7 +65,7 @@ fi | |||
|
|
|||
| # ensure WAL log bucket exists | |||
| envdir /etc/wal-e.d/env /app/bin/create_bucket "${BUCKET_NAME}" | |||
| INIT_ID=$(etcdctl get "$ETCD_PATH/initId" 2> /dev/null || echo none) | |||
| INIT_ID=$(etcdctl get -C $ETCD "$ETCD_PATH/initId" 2> /dev/null || echo none) | |||
There was a problem hiding this comment.
This has to be quoted: "$ETCD". Otherwise shellcheck will complain.
gabrtv
force-pushed
the
fix-db-recovery
branch
from
7f2e90d
to
7ca1b46
Compare
|
LGTM. |
|
lgtm |
gabrtv
pushed a commit
that referenced
this pull request
Sep 3, 2015
fix(database): use ETCD host during database recovery detection
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When troubleshooting failed database recovery on Azure, it seems we are failing to pull the
/deis/database/initIdfrom etcd even when it is populated. Upon closer inspection I noticed we are not passing in the list of etcd hosts to etcdctl. This PR passes-C $ETCDwhich seems to resolve the issue. This will require manual database failover testing.Reminder: all of these boot scripts need to be rewritten in Go. 馃槈