Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dockerbuilder should delete the image from the host once the push is done #29

Open
smothiki opened this issue Mar 1, 2016 · 7 comments
Open

dockerbuilder should delete the image from the host once the push is done #29

smothiki opened this issue Mar 1, 2016 · 7 comments
Assignees
@arschles
Labels
enhancement

Comments

@smothiki
Copy link
Contributor

smothiki commented Mar 1, 2016

reduces storage on the host
@smothiki smothiki self-assigned this Mar 1, 2016
arschles pushed a commit to arschles/deis-dockerbuilder that referenced this issue Mar 16, 2016
feat(rootfs/deploy.py): remove image after it's pushed
74d8b47 
Fixes deis#29
@arschles arschles mentioned this issue Mar 16, 2016
Merged
@arschles arschles assigned arschles and unassigned smothiki Mar 16, 2016
arschles pushed a commit to arschles/deis-dockerbuilder that referenced this issue Mar 30, 2016
feat(rootfs/deploy.py): remove image after it's pushed
2bfa39c 
Fixes deis#29
arschles pushed a commit to arschles/deis-dockerbuilder that referenced this issue Apr 21, 2016
feat(rootfs/deploy.py): remove image after it's pushed
b789391 
Fixes deis#29

fix(rootfs/deploy.py): use named params

fix(deploy.py): replace remote_image (typo) with remove_image

fix(deploy.py): fix another typo in noprune
arschles pushed a commit to arschles/deis-dockerbuilder that referenced this issue Apr 21, 2016
feat(rootfs/deploy.py): remove image after it's pushed
45932c3 
Fixes deis#29

fix(rootfs/deploy.py): use named params

fix(deploy.py): replace remote_image (typo) with remove_image

fix(deploy.py): fix another typo in noprune
@arschles arschles mentioned this issue Apr 27, 2016
Merged
@arschles
Copy link
Member

I'm reopening this for beta4, since it was reverted in #53 (in response to #52).

The issue with the change in #39 was that client.remove_image(image=registry+'/'+imageName, force=True, noprune=False) was removing the image from the registry, not the local docker daemon.

I think, but am not sure (and haven't tested) that client.remove_image(image=imageName, force=True, noprune=False) will delete the image from the local docker daemon.

@arschles arschles added this to the v2.0-beta4 milestone Apr 27, 2016
@bacongobbler bacongobbler reopened this Apr 27, 2016
@jchauncey jchauncey modified the milestones: v2.0-rc1, v2.0-beta4 May 10, 2016
@jchauncey
Copy link
Member

moved to rc1

@smothiki smothiki modified the milestones: v2.0, v2.0-rc1 May 23, 2016
@smothiki
Copy link
Contributor Author

moving this to v2.0 cause of some weird behavior happening need to do more research on this

@slack slack removed this from the v2.0 milestone Jun 3, 2016
@bacongobbler
Copy link
Member

doesn't kubernetes automatically clean up stale images on the host?

@smothiki
Copy link
Contributor Author

I don't think it's a kubernetes issue. I think it's happening from docker end .

@bacongobbler
Copy link
Member

related to this issue's interests would be deis/charts#352 which we could potentially pull in as a Workflow component eventually with some tweaking.

@felixbuenemann
Copy link

Related to deis/builder#487.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arschles arschles

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@slack @arschles @jchauncey @felixbuenemann @bacongobbler @smothiki