feat(*): configuring minio with SSL certs #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 tasks
|
Until Helm fixes this situation, I'm okay with doing things this way. (And even then we may need this for Makefile-based builds.) |
|
👍 Variable substitution would remove the need for manifest_replace.go and I would love that! I spent a while spinning my wheels on the best way to do it in a shell script before deciding it was cleaner in Go... Also, if Helm gets generators, I'm happy to contribute a ssl-cert-gen one. |
…scripts in more appropriate containers
and add the v2-alpha tag
kube-service tries to create secrets, which fails much of the time. in standard development, we’ll likely be starting up the rc more than creating new secrets
all the newline handling was making the sed command very complex. I believe the move to Go is justified here
arschles
added a commit
that referenced
this pull request
Dec 9, 2015
feat(*): configuring minio with SSL certs
|
note that we've decided not to run minio with ssl for alpha. see #1 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses part of #1