Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(Dockerfile): update deis/base to v0.3.6 #180

Merged
merged 1 commit into from
Jan 25, 2017

Conversation

bacongobbler
Copy link
Member

Awaiting deis/base:v0.3.6 to be released

@bacongobbler bacongobbler added this to the v2.11 milestone Jan 11, 2017
@bacongobbler bacongobbler self-assigned this Jan 11, 2017
@mboersma mboersma added the LGTM1 label Jan 11, 2017
@mboersma
Copy link
Member

I'm seeing this error when trying to build controller or builder locally after this same change:

Reading package lists...
Building dependency tree...
Reading state information...
0 upgraded, 0 newly installed, 0 to remove and 0 not upgraded.
gzip: /usr/share/copyrights.tar.gz has 20 other links -- unchanged
tar: Removing leading `/' from member names
tar: Removing leading `/' from hard link targets
gzip: /usr/share/copyrights.tar.gz already exists;	not overwritten

I think the fix in deis/controller#1203 may be pervasive. I'm not sure why CI was able to build these PRs, however--I would have thought it would hit the same issue, but it's consistent for me locally.

@mboersma
Copy link
Member

mboersma commented Jan 18, 2017

In this case (and probably others), that layer was cached, which prevented this error from showing itself. I think we need to build Docker images with --no-cache.

@mboersma
Copy link
Member

LGTM++

@bacongobbler bacongobbler merged commit 7fa8297 into deis:master Jan 25, 2017
@bacongobbler bacongobbler deleted the bump-deis-base-v0.3.6 branch January 25, 2017 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants