feat(quokka): add js event loop to runtime #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: Update quokka and acid to use accessor for vm (runtime.VM()) instead of as a field. |
technosophos
reviewed
Jun 7, 2017
pkg/javascript/runtime.go
Outdated
| // very intelligble at a glance. The idea is that | ||
| // ```t.call.ArgumentList[2:]``` contains the args | ||
| // for the callback given to setTimer and setInterval. | ||
| // This block is directly from from natto. |
technosophos
reviewed
Jun 7, 2017
| v, err := call.Otto.ToValue(t) | ||
| if err != nil { | ||
| // Again, not sure how we handle these errors? | ||
| // The beautiful evil hell of dynamic langs... |
There was a problem hiding this comment.
Please don't EVER remove this comment
technosophos
reviewed
Jun 7, 2017
| } | ||
| return ret, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
Can you add a comment on this function?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP it good.