Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "configuration extensions" #36

Closed
krancour opened this issue Dec 9, 2015 · 2 comments
Closed

Add support for "configuration extensions" #36

krancour opened this issue Dec 9, 2015 · 2 comments
Assignees
Labels
Milestone

Comments

@krancour
Copy link
Contributor

krancour commented Dec 9, 2015

In the back of my head, I want to make alternate implementations of router possible, so all along I've intended to avoid exposing configuration options that are nginx-specific. This is easier said than done because, frankly, even with more generic names, the bulk of the router configuration is nginx-specific. Getting creative in coming up with more generic names for things only ends up obfuscating the function of each option.

To work around this, I propose adding support for implementation-specific "extensions" to the router configuration. So, for instance, anything that is undeniably nginx specific and meaningless in the context of another hypothetical implementation (such as HAProxy), might be moved into an "extensions": { "nginx": { ... } } section of the configuration.

@krancour
Copy link
Contributor Author

krancour commented Feb 3, 2016

Just capturing some further thoughts on this before I lose them...

It goes without saying that alternative implementations of the router component would naturally support different configuration options that vary with the capabilities, limitations, and native dialect of the underlying tech. Options for Nginx vs HAProxy will be different and there's not much that can be done to smooth that over. But I think that doesn't matter...

The thing that matters is that the "contract" between deis-workflow (or alternative PaaS API/controller) and the router is always honored. When it comes down to it, there are a scant few configuration options that are affected by that and they revolve around the attributes of the AppConfig type.

The bottom line is that I think this issue can probably be adequately resolved through a reorganization of the documentation to separate the contractual / non-negotiable aspects of the configuration from the implementation-specific aspects.

@krancour
Copy link
Contributor Author

Replaced by #111

felixbuenemann pushed a commit to felixbuenemann/router that referenced this issue Dec 10, 2021
chore(Dockerfile): upgrade libmodsecurity to newest v3.0.3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants